Skip to content

feat: add msi support#1207

Open
6d7a wants to merge 6 commits intomainfrom
6d7a/msi
Open

feat: add msi support#1207
6d7a wants to merge 6 commits intomainfrom
6d7a/msi

Conversation

@6d7a
Copy link
Copy Markdown
Contributor

@6d7a 6d7a commented Apr 9, 2026 •
edited
Loading

What has been done

Adds windows .msi builds as a release artifact.
Closes #1174

Validation

  • Download the windows build artifacts from one of the CI runs
  • Install the .msi
  • Run ggshield --version from a new terminal session (the installer should have added ggshield to the PATH)

PR check list

  • As much as possible, the changes include tests (unit and/or functional)
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

agateau-gg and others added 5 commits April 9, 2026 18:01
@agateau-gg
feat: Add support for msi packages
86920dd
@agateau-gg @claude
fix(ci): upgrade WiX Toolset to v5 for Files element support
1b5d4d2 
WiX v4.0.4 does not support the <Files> element used in ggshield.wxs,
causing the MSI build to fail with WIX0005.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@agateau-gg @claude
fix: move Files element out of Component in WiX source
55e2514 
The <Files> element must be a direct child of <Directory>, not
<Component>. It auto-generates its own components.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@agateau-gg @claude
fix: use ComponentGroup for Files element in WiX source
dce77f4 
Files-generated components must belong to a Feature. Wrap the Files
element in a ComponentGroup and reference it via ComponentGroupRef.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: provide python dll in _internal subdirectory
5313484
@6d7a 6d7a requested a review from a team as a code owner April 9, 2026 16:16
@6d7a 6d7a marked this pull request as draft April 9, 2026 16:16
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.92%. Comparing base (d3b9004) to head (ba7edfa).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1207      +/-   ##
==========================================
+ Coverage   92.85%   92.92%   +0.06%     
==========================================
  Files         168      169       +1     
  Lines        8178     8309     +131     
==========================================
+ Hits         7594     7721     +127     
- Misses        584      588       +4
Flag Coverage Δ
unittests 92.92% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@6d7a 6d7a marked this pull request as ready for review April 10, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@6d7a @agateau-gg